Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from inspect.getargspec to inspect.getfullargspec #1945

Merged
merged 1 commit into from Feb 1, 2022
Merged

Switch from inspect.getargspec to inspect.getfullargspec #1945

merged 1 commit into from Feb 1, 2022

Conversation

domdfcoding
Copy link
Contributor

@domdfcoding domdfcoding commented Jan 29, 2022

inspect.getargspec() has been deprecated since 3.0 and has been removed in the 3.11 alphas.

What kind of change does this PR introduce?

  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

Fixes #1944

What is the current behavior? (You can also link to an open issue here)

An AttributeError is raised when importing cherrypy.

Other information:

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

inspect.getargspec has been deprecated since 3.0
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #1945 (8245a74) into main (a7983fe) will increase coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
+ Coverage   79.34%   80.03%   +0.68%     
==========================================
  Files         105      105              
  Lines       13394    13392       -2     
==========================================
+ Hits        10628    10718      +90     
+ Misses       2766     2674      -92     

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@webknjaz webknjaz merged commit 13fcf12 into cherrypy:main Feb 1, 2022
@Safihre
Copy link
Contributor

Safihre commented May 9, 2022

@webknjaz Will you create a new release of CherryPy? Because Python 3.11Beta is out and we can't use it because CherryPy is not working.

@domdfcoding domdfcoding deleted the getargspec branch June 3, 2022 15:25
@jaraco
Copy link
Member

jaraco commented Jul 11, 2022

I cut a release 18.7 in #1966.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError on Python 3.11
4 participants