-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a Loader to yaml.load #101
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyYAML 5.1 now emits a warning when `Loader` keyword argument is not specified to `yaml.load`.
tristan0x
force-pushed
the
fix-pyyaml-warnings
branch
from
March 29, 2019 13:28
9c70306
to
587c227
Compare
Hello @cheshirekow |
Hi @tristan0x, this looks good, thanks for submitting. I'll pull this in upstream and it should be in the next release. |
cheshirekow
added a commit
that referenced
this pull request
Apr 24, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#94`_: add config option keep_comment_line_blocks * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#94: #94 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 24, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#94`_: add config option keep_comment_line_blocks * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#94: #94 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 24, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#94`_: add config option keep_comment_line_blocks * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#94: #94 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 24, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#94`_: add config option keep_comment_line_blocks * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#94: #94 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 28, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 28, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 28, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
cheshirekow
added a commit
that referenced
this pull request
Apr 28, 2019
* Implement canonical command case * Canonicalize capitalization of keys in cmdspec * Add README documentation regarding fences and enable/disable * Statement parsers are now generic functions. Old standard parser remains for most statements, but some statements now have custom parsers. * Implement deeper parse logic for ``install()`` and ``file()`` commands, improving the formatting of these statements. * Implement input/output encoding configuration parameters * Implement hashruler markup logic and preserve hashrulers if markup is disable or if configured to do so. * Separate cmake-annotate frontend * Provider a ``Loader=`` to yaml ``load()`` * Fix python3 lint * Fix bad lexing of make-style variables * Fix multiple hash chars ``lstrip()ed`` from comments * Closes `#62`_: Possible improvement on formatting "file" * Closes `#75`_: configurable positioning of flags * Closes `#87`_: Hash-rulers are stripped when markup disabled * Closes `#91`_: Add missing keyword arguments to project command * Closes `#95`_: added argument --encoding to allow for non-utf8 * Closes `#98`_: Fix kwargs/flag index for non-lowercase functions * Closes `#100`_: Extra linebreak inserted when '$(' encountered * Closes `#101`_: Provide a Loader to yaml.load * Closes `#102`_: fences does not work as expected .. _#62: #62 .. _#75: #75 .. _#87: #87 .. _#91: #91 .. _#95: #95 .. _#98: #98 .. _#100: #100 .. _#101: #101 .. _#102: #102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyYAML 5.1 now emits a warning when
Loader
keyword argument is not specifiedto
yaml.load
.