Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour icons, and convert to 25x25. #7

Merged
merged 3 commits into from Sep 4, 2016
Merged

Add colour icons, and convert to 25x25. #7

merged 3 commits into from Sep 4, 2016

Conversation

bwinton
Copy link
Contributor

@bwinton bwinton commented Aug 31, 2016

as per the migration guide

It now looks like this in the launcher:
pebble_screenshot_2016-08-30_21-58-47

and this in the splash screen:
pebble_screenshot_2016-08-30_22-00-27

@chesterbr
Copy link
Owner

Oh, those are cute - great job! 🌈

@chesterbr
Copy link
Owner

Ah, I wanted to notice that, but my emulator is busted. Anyway, I tested on a Pebble Classic (aplite), and got the background issue with the PR (before the last commit):

pebble_pr_-_carlos_nascimento_shopify_com_-_shopify_mail

whereas the original app fills it in nicely:

img_20160831_084056

Pebble Round (Chalk) seemed to work fine.

Does the last commit also change it for Aplite? (I can test it later)

@bwinton
Copy link
Contributor Author

bwinton commented Aug 31, 2016

It didn't, but I tried changing it back to "bitmap". Can you let me know if that fixes it?
(I can't seem to get to the menu in the aplite emulator, but this latest version looks fine on basalt, chalk, and diorite…)

@chesterbr
Copy link
Owner

Still the same result :-(

I remember making this work required changing the bitmap to a 1-bit pallet (done here for the old icon) and adding the "memoryFormat": "1Bit" and (counter-intuitively) the "type": "bitmap", (here). I just don't remember how I did the conversion...

@chesterbr
Copy link
Owner

Just to illustrate, in your branch:

$ file resources/img/streetcar2525.png
resources/img/streetcar2525.png: PNG image data, 25 x 25, 8-bit/color RGB, non-interlaced

whereas the original was:

$ file resources/img/streetcar2828.png
resources/img/streetcar2828.png: PNG image data, 28 x 28, 1-bit colormap, non-interlaced

@chesterbr
Copy link
Owner

But mind you, I've just added the "memoryFormat": "1Bit" back and the transparency worked, even with the 8-bit file, so I guess that would be the solution)

(that said, ImageMagick does the conversion if you ask really nicely:

$ convert resources/img/streetcar2525.png -background white -type palette -depth 1 -colors 2 output.png
$ file output.png
output.png: PNG image data, 25 x 25, 1-bit grayscale, non-interlaced

)

@chesterbr chesterbr merged commit 0cff28e into chesterbr:master Sep 4, 2016
@chesterbr
Copy link
Owner

I've added that parameter (doesn't seem to affect colour displays) and merged, will complete with credits and publish soon. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants