This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Clean up project #49
Merged
Clean up project #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve modularity by outsourcing the nav and footer tags into distinct files. Signed-off-by: Dominik Prodinger <prodinger.d@outlook.com>
Page files are now located within the _pages folder to clean up the root directory. Signed-off-by: Dominik Prodinger <prodinger.d@outlook.com>
Signed-off-by: Dominik Prodinger <prodinger.d@outlook.com>
Signed-off-by: Dominik Prodinger <prodinger.d@outlook.com>
This reverts commit 628e6dc.
chesterhow
suggested changes
Oct 3, 2018
|
Ok, but is it referenced anywhere? The favicon files which are being used are located in the |
|
Its not. “favicon.ico” file just needs to be placed in the root folder of directory and the browser will detect it automatically. |
This reverts commit 18b32be.
|
Reverted the commit in question! :) |
chesterhow
approved these changes
Oct 5, 2018
|
Thanks! Looks good to me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #48.