Files for SSL config (certs, etc) were not closed. closes nahi#8.

chetan · Nov 2, 2009 · c737a84 · c737a84
1 parent d24ab1d
commit c737a84
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/httpclient/ssl_config.rb b/lib/httpclient/ssl_config.rb
@@ -112,8 +112,8 @@ def client_key=(client_key)
     #
     # Calling this method resets all existing sessions.
     def set_client_cert_file(cert_file, key_file)
-      @client_cert = X509::Certificate.new(File.open(cert_file).read)
-      @client_key = PKey::RSA.new(File.open(key_file).read)
+      @client_cert = X509::Certificate.new(File.open(cert_file) { |f| f.read })
+      @client_key = PKey::RSA.new(File.open(key_file) { |f| f.read })
       change_notify
     end
 
@@ -158,7 +158,7 @@ def set_trust_ca(trust_ca_file_or_hashed_dir)
     # Calling this method resets all existing sessions.
     def set_crl(crl)
       unless crl.is_a?(X509::CRL)
-        crl = X509::CRL.new(File.open(crl).read)
+        crl = X509::CRL.new(File.open(crl) { |f| f.read })
       end
       @cert_store.add_crl(crl)
       @cert_store.flags = X509::V_FLAG_CRL_CHECK | X509::V_FLAG_CRL_CHECK_ALL