Added the hide blog feature #50
Conversation
yourData.json named "hideBlog". and hid the blog values from navigation.
✅ Deploy Preview for react-portfolio-template ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Go ahead And merge Away 🚀 |
I can't merge this. I don't have write access, only you can merge |
|
Hi nice job! Just a question, if someone were to put in /blog after the URL, wouldn't the route still exist? We are only removing the button here. Maybe we can work on this enhancement later. A very minor issue tbh, great work on the commit 😄 |
| @@ -120,6 +120,9 @@ export default { | |||
| aboutpara: | |||
| "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.", | |||
| // End About Section --------------------- | |||
|
|
|||
| // Hide Blog section | |||
| hideBlog: true, | |||
There was a problem hiding this comment.
Can this be moved to the top of the json file? It may be more helpful to keep it at the top.
| {data.name}. | ||
| </h1> | ||
| {!isBlog ? ( | ||
| <div className="flex"> | ||
| <Button onClick={handleWorkScroll}>Work</Button> | ||
| <Button onClick={handleAboutScroll}>About</Button> | ||
| <Button onClick={() => router.push("/blog")}>Blog</Button> | ||
| {!data.hideBlog && ( |
There was a problem hiding this comment.
Can we destructure this variable from the data object? Just makes it a bit more readable.
There was a problem hiding this comment.
@achu-krishna Once you are done with this resolution we can merge!
There was a problem hiding this comment.
@chetanverma16 @Aryan3212 Sure I will do it ASAP
I noticed that too. We could create a new issue for that |
@achu-krishna For sure! |
|
Yeah, @achu-krishna Nice Work! |
Add a new field in the
yourData.jsonnamedhideBlogwhich is a boolean field.In the
Header/index.jsused logical and operator to hide the navItem