Exposed Developers Filesystem #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see. Its for the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may have been a feature rather than an issue before. However, by exposing the direct filepath you are also exposing the Developers filesystem. This may be simply an annoyance at times but could result in something far worse depending on how
/super/secret/the/file/system/is.Whats worse is that anyone using this module may have no idea they are exposing themselves like this. You may keep this if it is indeed a feature, however please notify people the path to the browserify-css module will be fully exposed.
Additionally, this will reduce the amount of arbitrary diffs between two different developers if the browserified result is not ignored