Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes audit errors and deprecation warnings #4

Merged
merged 5 commits into from
Jan 17, 2019
Merged

fixes audit errors and deprecation warnings #4

merged 5 commits into from
Jan 17, 2019

Conversation

retorquere
Copy link
Contributor

No description provided.

@cheton
Copy link
Owner

cheton commented Jan 17, 2019

The change to the source code is also required.

@retorquere
Copy link
Contributor Author

Which changes? I ran npm test and it succeeded.

@cheton
Copy link
Owner

cheton commented Jan 17, 2019

No tests were implemented for this package. It's necessary to switch legacy API from github to @octokit/rest for the code: https://github.com/cheton/github-release-cli/blob/master/src/index.js#L4

@retorquere
Copy link
Contributor Author

Done

@cheton cheton merged commit 96455bf into cheton:master Jan 17, 2019
@cheton
Copy link
Owner

cheton commented Jan 18, 2019

Thank you!

@retorquere
Copy link
Contributor Author

My pleasure, but I saw you had to fix a lot of niggles - sorry about those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@retorquere @cheton