Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types in index.d.ts #12

Merged
merged 1 commit into from Feb 21, 2023
Merged

Fix types in index.d.ts #12

merged 1 commit into from Feb 21, 2023

Conversation

hpello
Copy link
Contributor

@hpello hpello commented Feb 15, 2023

Description

The current index.d.ts triggers an error:

../../node_modules/is-electron/index.d.ts:1:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

1 function isElectron (): boolean
  ~~~~~~~~

In this PR, we fix this error.

@hpello
Fix types in index.d.ts
c0ba219 
Error message was:

Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
@hpello
Copy link
Contributor Author

hpello commented Feb 21, 2023 •
edited

Hello @cheton! Could you take a look at this PR? 🙂
We need it to keep using is-electron in our TS codebase.

@cheton cheton merged commit a25d62a into cheton:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hpello @cheton