Create a SSL CSR #10
Closed
Create a SSL CSR #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_value(self): | ||
| """ | ||
| Options are parsed form command line. |
|
Just some minor comments. changes-approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to create CSR + key from command line but also from Python API
Changes
Created 3 new methods. one to generate the commnad line options, another one to to generate the key/csr and another one to take care of writing to disk.
As a drive by I have updated the test runner to print speed reports and wrote a test for self signed certificate so that we have 100% coverage for ssl module.
How to test
reviewers: @alibotean
check that changes make sense
Use the demo tool to generate a csr