Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for jq #4

Merged
merged 1 commit into from Jun 28, 2021
Merged

Better support for jq #4

merged 1 commit into from Jun 28, 2021

Conversation

crystalin
Copy link
Contributor

jq without . fails when piped. See jqlang/jq#1110
this PR prevents this from happening

@chevdor
Copy link
Owner

chevdor commented Jun 26, 2021

Hello @crystalin, thanks for the PR. Do you have a link where it fails in the context of srtool ?

I need some updates here in general for the new version of srtool so I will test your PR while testing the rest.

Is it blocking you for now? Does your CI fail due to that ?

The issue you linked is super old so I wonder if jq was not fixed in the meantime as I did not run into the issue yet.

@crystalin
Copy link
Contributor Author

crystalin commented Jun 26, 2021 via email

@chevdor chevdor merged commit 9675fde into chevdor:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants