-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hardcoded docker occurences. #23
Conversation
This is a very welcome fix. Thank you. I also think it would be good in general to switch the default to Podman but I want to make sure we do not suprise the users who may not have a Podman install ready to be used. Ideally, the doc should be reworked to mention something more neutral than Docker and use the word "containers" instead. Quick optionI am thinking that we could drop a warning if the engine is set to Smarter optionAs alternative, we could be smart about it and check whether podman and docker are installed and use as engine:
In term of detection (I ran into this recently), we need to make sure we don't stop at just finding the "command". Using
The above could be done in this PR or in another one. Your pick :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
@chevdor Sorry that it took a while, but I had stuff to do 🤷♂️ Hope you are happy with the result! |
No stress and thanks for the work! |
- move the ContainerEngine related fn to the appropriate file - switch the engine type type to ContainerEngine (String formerly) and add value_parser - error cleanup - set --no-cache by default for Podman - add doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included a few fixes directly
This PR removes two hardcoded occurences of the docker container engine. Since a few weeks, users can choose to use podman instead of docker, but in some places "docker" was still not made dynamic.
fixes #22