Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: include #9

Merged
merged 9 commits into from
Sep 7, 2021
Merged

Feature: include #9

merged 9 commits into from
Sep 7, 2021

Conversation

tandiljuan
Copy link
Contributor

New branch with (just) include feature (from #7).

Copy link
Owner

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good besides the 2 formatting issues

src/opts.rs Outdated
@@ -11,6 +11,15 @@ pub struct Opts {
#[clap(short, long)]
pub template: PathBuf,

/// This flag tells the command to parse all templates found in the same
/// path where the given template is located.
#[clap(short, long, visible_alias="inherit")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[clap(short, long, visible_alias="inherit")]
#[clap(short, long, visible_alias = "inherit")]

src/opts.rs Outdated
pub include: bool,

/// Option to define a different path from which search and parse templates.
#[clap(long, visible_alias="inherit-path")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[clap(long, visible_alias="inherit-path")]
#[clap(long, visible_alias = "inherit-path")]

@tandiljuan
Copy link
Contributor Author

Hi @chevdor . I have applied the requested updates.

@chevdor chevdor merged commit 592f365 into chevdor:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants