Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug for more types #3

Open
geeklint opened this issue Apr 5, 2023 · 0 comments
Open

impl Debug for more types #3

geeklint opened this issue Apr 5, 2023 · 0 comments

Comments

@geeklint
Copy link

geeklint commented Apr 5, 2023

Most types benefit from a Debug implementation, and it looks like only Rect supports it in this crate right now.

Specifically, the lack of the Debug trait for PackedItem means that you can't .unwrap() or .expect() the result of Packer::pack.

I think you should be able to add #[derive(Debug)] to all of {Item, PackedItem, PackedItems, Packer, and Rotation}. It looks like maybe you were avoiding it on the generic types but the derive macro should handle the generic type correctly for this crate's purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant