Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the build system #171

Merged
merged 6 commits into from Feb 3, 2024
Merged

Modernize the build system #171

merged 6 commits into from Feb 3, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Feb 3, 2024

  1. Remove the cmake-fedora boilerplate. Newer cmake is much more ergonomic to use since then.
  2. Commit gob2 generated files to repo. This will allow us to replace gob2 with either hand written gobjects, Vala, or gtk-rs.
  3. Remove rpm specs. The spec in Fedora has already diverged.

Copy link

codecov bot commented Feb 3, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kanru kanru merged commit 1de53bf into master Feb 3, 2024
5 checks passed
@kanru kanru deleted the modernize-1 branch February 3, 2024 14:54
@kanru kanru added this to the 2.0.0 milestone Feb 6, 2024

Change CMAKE_INSTALL_PREFIX and LIBEXEC_DIR if you want to install
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBEXEC_DIR is still necessary as it's used in some places: https://github.com/search?q=repo%3Achewing%2Fibus-chewing%20LIBEXEC_DIR&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants