-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate tsi.src and phone.cin #214
Comments
I think we already has some checks implemented in https://github.com/chewing/libchewing/blob/master/src/tools/init_database.c for |
init_database.c is tolerance to errors and more robust. For example,
I'd like to have stricter validator. |
@kcwu, do you think we can just use a stricter parser in |
These two definitely should be rejected by init_database.c
For blank line and extra spaces (and sorting order), I'm not sure should we enforce or not. |
I can't understand the above descriptions of the situation that init_database.c should avoid. |
tsi.src and phone.cin were often broken in the past.
Not only sorting order, sometimes the syntax is bad (missing frequency, extra space, illegal bopomofo, etc.)
We should validate them in CI to keep them in good state.
Before somebody write the validation code, checking the sorting order seems a good start.
cc @PeterDaveHello
The text was updated successfully, but these errors were encountered: