Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement has_userphrase with chewing_userphrase_lookup #223

Merged
merged 1 commit into from Jun 10, 2016
Merged

Implement has_userphrase with chewing_userphrase_lookup #223

merged 1 commit into from Jun 10, 2016

Conversation

ShengYenPeng
Copy link
Contributor

@ShengYenPeng ShengYenPeng commented May 21, 2016

issue #96

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.526% when pulling 7531e86 on ShengYenPeng:master into f353c37 on chewing:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.564% when pulling 8a12c0d on ShengYenPeng:master into 52a49da on chewing:master.

@ShengYenPeng
Copy link
Contributor Author

Hi @jserv , can you give me some suggestion for this pull request?

@jserv
Copy link
Member

jserv commented Jun 9, 2016

You have to explain the rationale with the commits and the exact reason why you implement something by deleting the code.

@ShengYenPeng
Copy link
Contributor Author

The libchewing use internal_has_userphrase to implement has_userphrase by
#define has_userphrase() internal_has_userphrase().

According to czchen's description in issue 96,

After chewing_userphrase_lookup is implemented, has_userphrase shall use chewing_userphrase_lookup instead of libchewing internal functions.

I redefine has_userphrase by
#define has_userphrase() chewing_userphrase_lookup()

I think internal_has_userphrase is a temporary function waiting for chewing_userphrase_lookup,
now that chewing_userphrase_lookup has been implemented, we don't need internal_has_userphrase anymore.

@jserv
Copy link
Member

jserv commented Jun 10, 2016

Update GIT commit messages accordingly.

Redefine has_userpharse by #define has_userphrase() chewing_userphrase_lookup()
and we do not need internal_has_userphrase() anymore.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.564% when pulling aa38846 on ShengYenPeng:master into 74feae3 on chewing:master.

@jserv jserv merged commit 819cdb7 into chewing:master Jun 10, 2016
@jserv
Copy link
Member

jserv commented Jun 10, 2016

@ShengYenPeng : Thanks for your contribution.

@ShengYenPeng
Copy link
Contributor Author

thanks for your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants