✨ (yaldap): Add password hash mecanism #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunleii
added
size: L
xunleii
force-pushed
the
add-password-hash
branch
2 times, most recently
from
57895e8
to
af608cb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 89.96% 87.39% -2.57%
==========================================
Files 17 18 +1
Lines 787 865 +78
==========================================
+ Hits 708 756 +48
- Misses 55 78 +23
- Partials 24 31 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Storing plain-text password is not a good practice at all. So, in order to improve a bit the security of this project, I add the ability to store hashed password that can be managed transparently during the LDAP BIND request. Currently, yaLDAP only manages argon2, bcrypt, pbkdf2 and scrypt hashed password.
In order to create password hash for the LDAP configuration, I changed how the CLI works. BREAKING CHANGES: The dockerfile entrypoint has changed and we must provide the `run` command before argument
The yaLDAP owner has been changed without updating their references
xunleii
force-pushed
the
add-password-hash
branch
from
af608cb
to
4d987bc
Compare
xunleii
force-pushed
the
add-password-hash
branch
3 times, most recently
from
b7cb157
to
8e34a28
Compare
xunleii
added a commit
that referenced
this pull request
May 24, 2024
✨ (yaldap): Add password hash mecanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to store password as hash that will be used transparently during the
bindoperation.