Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jpype optional #369

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Make jpype optional #369

merged 1 commit into from
Nov 19, 2023

Conversation

chezou
Copy link
Owner

@chezou chezou commented Nov 19, 2023

Description

To approach #368, make jpype installation extra dependency.

Motivation and Context

Since jpype hasn't supported Python 3.12 yet, it'd be better to make it optional to work tabula-py on Python 3.12.

How Has This Been Tested?

Unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou chezou merged commit 76db276 into master Nov 19, 2023
2 checks passed
@chezou chezou deleted the opt-jpype branch November 19, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant