Verify against difficulty #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 98.58% 98.65% +0.06%
==========================================
Files 24 24
Lines 1840 1929 +89
==========================================
+ Hits 1814 1903 +89
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add new Ethash verification function which takes difficulty number directly. Previously only verify_against_boundary() was available which required converting difficulty to boundary (division). The new verify_against_difficulty() performs check hash * difficulty <= 2^256 and division is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new Ethash verification function
verify_against_difficulty()which takes difficulty numberdirectly. Previously only
verify_against_boundary()was available which required converting difficulty to boundary (division) by users. The new verify_against_difficulty() performs checkhash * difficulty <= 2^256and division is not needed.Closes #185.