Cleanup umul() #195
Merged
Cleanup umul() #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
===========================================
- Coverage 100.00% 99.10% -0.90%
===========================================
Files 9 9
Lines 2332 2335 +3
===========================================
- Hits 2332 2314 -18
- Misses 0 21 +21 |
gumb0
force-pushed
the
cleanup-umul
branch
3 times, most recently
from
18eda72
to
8d4d5c0
Compare
|
@chfast Not sure what to do with coverage here, any ideas? |
chfast
reviewed
Mar 1, 2021
| #if defined(__SIZEOF_INT128__) | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wpedantic" | ||
| if (!is_constant_evaluated()) |
There was a problem hiding this comment.
Using builtin uint128 is fine in constexpr too. The is_constant_evaluated() is only actually needed for MSVC usage of intrinsic. We can keep it if not too big problem.
Yes, the 32-bit will not have |
This has landed, you can rebase now. |
chfast
force-pushed
the
cleanup-umul
branch
4 times, most recently
from
e1658b3
to
d297c13
Compare
chfast
approved these changes
Mar 4, 2021
Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #180 with a test fixed in a boring way.