Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

An in-range update of react-modal is breaking the build 🚨 #21

Closed
greenkeeper bot opened this issue Sep 25, 2018 · 1 comment
Closed

An in-range update of react-modal is breaking the build 🚨 #21

greenkeeper bot opened this issue Sep 25, 2018 · 1 comment

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Sep 25, 2018

The dependency react-modal was updated from 3.5.1 to 3.6.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

react-modal is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 5 commits.

  • 2a70831 Release v3.6.1.
  • a2c38cc [fixed] set default role for accessibility
  • 921358e Add explicit comments as suggested in PR review
  • 3d74c1b Update doc to inform v3 users about close transition
  • 1e349c0 [fixed] remove aria-modal attr to prevent browser bugs

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Sep 25, 2018

After pinning to 3.5.1 your tests are passing again. Downgrade this dependency 📌.

@ChFlick ChFlick closed this as completed Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant