Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change All Relative Paths in Dynamically Generated HTML to Absolute Paths #39

Closed
chgibb opened this issue Nov 12, 2016 · 0 comments
Closed

Comments

@chgibb
Copy link
Owner

chgibb commented Nov 12, 2016

Due to Browserify's path resolution, all paths used in dynamically generated HTML should be prefixed by process.cwd() in order to make them absolute paths and prevent paths from being automatically expanded on by Browserify. This behaviour prevents actual deployment of any build as all expanded paths expand into an absolute path into the project directory where the project was built in.

  • Prefix paths directly with process.cwd()
  • Use fsAccess in order to modify the path string. This would likely be a better solution. Though, would require splitting of fsAccess out of each window/module and into it's own module file.
  • Manual testing for any fix will be very difficult due the nature of the error. Constant deletion/renaming of the project directory will be required in order to ensure that any expanded paths pointing into it are broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant