Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django-taggit 1.0+ support #25

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

vdboor
Copy link
Contributor

@vdboor vdboor commented Apr 12, 2019

This commit fixes taggit-selectize support for django-taggit >= 1.0.

The fix for has_changed() support in django-taggit changed the widget value:
jazzband/django-taggit@fa36187
A simple instance check allows this package to support both versions.

The fix for has_changed() support in django-taggit changed the widget value:
jazzband/django-taggit@fa36187
A simple instance check allows this package to support both versions.

Fixes: chhantyal#24
@chhantyal
Copy link
Owner

Thanks, looks like it will be backward compatible. So I will merge it :)

@chhantyal chhantyal merged commit 8990aa6 into chhantyal:master Apr 13, 2019
@vdboor vdboor deleted the fix-django-taggit-compat branch April 15, 2019 12:17
@vdboor
Copy link
Contributor Author

vdboor commented Apr 19, 2019

Hi @chhantyal I noticed a 2.7.0 release and tag in the git history but it wasn't uploaded to PyPI: https://pypi.org/project/taggit-selectize/#history did something go wrong here?

@chhantyal
Copy link
Owner

Hi @vdboor you are right. Unfortunately my PyPI account doesn't work anymore. I have no idea what is the issue, I can't seem to upload anymore.

Do you have PyPI account? I could add you as collaborator on Github and PyPI

@vdboor
Copy link
Contributor Author

vdboor commented Apr 30, 2019

@chhantyal Does uploading with 'twine' work? I think they've tightened the upload security.

My PyPI hande is 'vdboor' as well, I'd be happy to to the upload for you. While I don't plan on doing $random maintenance work, I'd be happy to fix things when I come across them as well.

@chhantyal
Copy link
Owner

Oh it was password issue. I uploaded new version https://pypi.org/project/taggit-selectize/2.7.0/

Thanks for notifying me :)

@vdboor
Copy link
Contributor Author

vdboor commented May 1, 2019

Hmm @chhantyal something is still off. I can't pip install it.

The files of 2.6.0 consist of:

  • taggit_selectize-2.6.0-py2.py3-none-any.whl (wheel pakage)
  • taggit-selectize-2.6.0.tar.gz (source package)

The files of 2.7.0 consist of:

  • taggit-selectize-2.7.0.macosx-10.13-x86_64.tar.gz (source)

What are you doing other then this?

rm -Rf build dist
./setup.py sdist bdist_wheel  && twine upload ./dist/*

@chhantyal
Copy link
Owner

Sorry I messed up the build. I pushed new release with wheel.

I can't seem to upload source dist anymore. PyPi is really driving me crazy. It keeps changing & messing up release command that used to work.

Error when trying to upload sdist.

HTTPError: 400 Client Error: File already exists. See https://pypi.org/help/#file-name-reuse for url: https://upload.pypi.org/legacy/

which is wrong because sdist file is not there.

Anyway, install should work now as wheel file is there https://pypi.org/project/taggit-selectize/2.7.1/#files

pip install taggit-selectize==2.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants