-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix django-taggit 1.0+ support #25
Conversation
The fix for has_changed() support in django-taggit changed the widget value: jazzband/django-taggit@fa36187 A simple instance check allows this package to support both versions. Fixes: chhantyal#24
0e9dca5
to
699bbd7
Compare
Thanks, looks like it will be backward compatible. So I will merge it :) |
Hi @chhantyal I noticed a 2.7.0 release and tag in the git history but it wasn't uploaded to PyPI: https://pypi.org/project/taggit-selectize/#history did something go wrong here? |
Hi @vdboor you are right. Unfortunately my PyPI account doesn't work anymore. I have no idea what is the issue, I can't seem to upload anymore. Do you have PyPI account? I could add you as collaborator on Github and PyPI |
@chhantyal Does uploading with 'twine' work? I think they've tightened the upload security. My PyPI hande is 'vdboor' as well, I'd be happy to to the upload for you. While I don't plan on doing $random maintenance work, I'd be happy to fix things when I come across them as well. |
Oh it was password issue. I uploaded new version https://pypi.org/project/taggit-selectize/2.7.0/ Thanks for notifying me :) |
Hmm @chhantyal something is still off. I can't pip install it. The files of 2.6.0 consist of:
The files of 2.7.0 consist of:
What are you doing other then this?
|
Sorry I messed up the build. I pushed new release with wheel. I can't seem to upload source dist anymore. PyPi is really driving me crazy. It keeps changing & messing up release command that used to work. Error when trying to upload sdist.
which is wrong because sdist file is not there. Anyway, install should work now as wheel file is there https://pypi.org/project/taggit-selectize/2.7.1/#files
|
This commit fixes taggit-selectize support for django-taggit >= 1.0.
The fix for has_changed() support in django-taggit changed the widget value:
jazzband/django-taggit@fa36187
A simple instance check allows this package to support both versions.