Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace punycode module due to deprecation #165

Open
cowwoc opened this issue Mar 2, 2024 · 4 comments
Open

Replace punycode module due to deprecation #165

cowwoc opened this issue Mar 2, 2024 · 4 comments

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Mar 2, 2024

Node v21.5.0

(node:23616) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:397:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:333:10)
    at loadBuiltinModule (node:internal/modules/helpers:101:7)
    at Module._load (node:internal/modules/cjs/loader:1000:17)
    at Module.require (node:internal/modules/cjs/loader:1234:19)
    at require (node:internal/modules/helpers:176:18)
    at ../../node_modules/node-fetch/node_modules/whatwg-url/lib/url-state-machine.js (C:\Users\Gili\Documents\licensed-app\client\browser\node_modules\.pnpm\@chialab+esbuild-plugin-html@0.18.0\node_modules\node_modules\node-fetch\node_modules\whatwg-url\lib\url-state-machine.js:2:18)
    at __require2 (file:///C:/Users/Gili/Documents/licensed-app/client/browser/node_modules/.pnpm/@chialab+esbuild-plugin-html@0.18.0/node_modules/@chialab/esbuild-plugin-html/dist/index.js:26:50)
    at ../../node_modules/node-fetch/node_modules/whatwg-url/lib/URL-impl.js (C:\Users\Gili\Documents\licensed-app\client\browser\node_modules\.pnpm\@chialab+esbuild-plugin-html@0.18.0\node_modules\node_modules\node-fetch\node_modules\whatwg-url\lib\URL-impl.js:2:13)
@cowwoc
Copy link
Contributor Author

cowwoc commented Mar 2, 2024

Per https://github.com/mathiasbynens/punycode.js?tab=readme-ov-file#installation it sounds like you just need to replace your import from punycode to punycode/.

@edoardocavazza
Copy link
Member

it seems that punycode is a sub-sub-dependency of jsdom. I'ill try to update the library.

@edoardocavazza
Copy link
Member

Updating JSDOM does not solve the issue.
jsdom/jsdom#3613

@cowwoc
Copy link
Contributor Author

cowwoc commented Mar 5, 2024

Do you plan to use their pre-release (due out at the end of this week)? Or will you wait for v5 which may take a while?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants