Plot keyword added to gofnt function #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e how it is normally run.
tdwilkinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to use the contribution function with multiple ions, I have added a plot=True keyword to the function. This is set to True by default as to not affect the normal operations of this function. However, in the event of evaluating multiple ions, setting the plot=False will only return the self.Gofnt attribute. This is the least amount of code edits that I could make and obtain this attribute. I was not able to use Intensity when analysing multiple ions (as suggested) due to needing to know the top lines for each ion. It was suggested to implement a self.TopLines in _ionTrails, but topLines is defined in intensityratio (another plotting function), and would require more edits than adding in this keyword and edits to the gofnt function.