Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full d3.time aggregation support #7

Closed
curran opened this issue Nov 28, 2015 · 1 comment
Closed

Add full d3.time aggregation support #7

curran opened this issue Nov 28, 2015 · 1 comment

Comments

@curran
Copy link
Contributor

curran commented Nov 28, 2015

All interval types from d3.time should be made available in the chiasm-crossfilter configuration.

This has been partially implemented the Migrant Deaths over Time Example. This implementation can be generalized to work with all intervals.
curran added a commit that referenced this issue Dec 3, 2015
@curran
Add test for temporal grouping. A step towards #7
71c9ae4
@curran curran closed this as completed in 3b34419 Dec 4, 2015
@curran
Copy link
Contributor Author

curran commented Dec 4, 2015

The current implementation uses local time, which is causing tests to break on Travis CI. This could be problematic when publishing visualizations, because users will get different aggregation results depending on which time zone they are in. Perhaps it's better to use UTC intervals for the aggregations.

@curran curran reopened this Dec 4, 2015
@curran curran closed this as completed in b7406c2 Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@curran