Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a way to commit changes immediately with commit() #22

Merged
merged 2 commits into from
Dec 16, 2016
Merged

a way to commit changes immediately with commit() #22

merged 2 commits into from
Dec 16, 2016

Conversation

Miha-x64
Copy link
Contributor

No description provided.

@Miha-x64 Miha-x64 mentioned this pull request Dec 15, 2016
Closed
@chibatching chibatching self-requested a review December 16, 2016 07:08
chibatching
chibatching reviewed Dec 16, 2016
View reviewed changes
Copy link
Owner

@chibatching chibatching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion and commit!
Your changes looks good for me, but please add unit test that check your new method immediateBulk .
Currently, it might be same as normal bulk test.

@Miha-x64
Copy link
Contributor Author

@chibatching thank you for fast feedback! You've got so many tests :)
I've copied your bulk tests and made immediateBulk versions of them.

@chibatching chibatching merged commit 097e27a into chibatching:master Dec 16, 2016
@chibatching
Copy link
Owner

@Miha-x64 I merged your PR! I will release new version in a few days. Thanks!

@chibatching
Copy link
Owner

close #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibatching chibatching chibatching left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Miha-x64 @chibatching