Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list and other models with gsonPref #88

Merged
merged 6 commits into from
Feb 18, 2018
Merged

Support list and other models with gsonPref #88

merged 6 commits into from
Feb 18, 2018

Conversation

wrozwad
Copy link
Contributor

@wrozwad wrozwad commented Feb 7, 2018

fixes #87

Copy link
Owner

@chibatching chibatching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your PR!
It looks good for me, but CI failed because compile error.
Can you fix it?

@codecov
Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   59.38%   59.38%           
=======================================
  Files          23       23           
  Lines         261      261           
  Branches       57       57           
=======================================
  Hits          155      155           
  Misses         60       60           
  Partials       46       46
Impacted Files Coverage Δ
...batching/kotpref/gsonpref/KotprefGsonExtentions.kt 33.33% <0%> (ø) ⬆️
...m/chibatching/kotpref/gsonpref/GsonNullablePref.kt 53.84% <100%> (ø) ⬆️
...otlin/com/chibatching/kotpref/gsonpref/GsonPref.kt 50% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8ca87...e934cfc. Read the comment docs.

@wrozwad
Copy link
Contributor Author

wrozwad commented Feb 12, 2018

So... I added missing imports but it's not my fault that it doesn't hit 50% diff target 😛

@chibatching chibatching merged commit b31433b into chibatching:master Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support list and other models with gsonPref
2 participants