Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner image does not display on iOS devices #40

Closed
tomschenkjr opened this issue Jan 13, 2015 · 12 comments
Closed

Banner image does not display on iOS devices #40

tomschenkjr opened this issue Jan 13, 2015 · 12 comments
Assignees
Milestone

Comments

@tomschenkjr
Copy link
Contributor

Confirmed on iPad and iPhone. Appears to be a problem with the type of effect I'm using for parallax. Some documentation points out the use of jQuery is better, so will explore those options.

@tomschenkjr tomschenkjr self-assigned this Jan 13, 2015
@tomschenkjr tomschenkjr added this to the Public code release milestone Jan 13, 2015
@SEV2014
Copy link

SEV2014 commented Jan 22, 2015

1/22/15 Team sprint planning: To be included sprint3

@tomschenkjr
Copy link
Contributor Author

Handing this over to @skishchampi to look at. The library Stellar.js seems to be the suggested solution, have not had time to figure it out.

@SEV2014 SEV2014 modified the milestones: sprint3, sprint4 Feb 6, 2015
@skishchampi
Copy link
Contributor

finally...
photo

@tomschenkjr
Copy link
Contributor Author

Beautiful...well-deserved 👍 and you definitely deserve the satisfaction of closing this issue.

@skishchampi
Copy link
Contributor

But I don't have iPad here. Also, This is optimized for iphone 4 (320*480). Will go find a few more devices (iphone 6 may be) and test it on them before I close it...

  1. The most obscure issue here was how Safari looks at JPG encoding. It doesn't render images if they have been "progressively" encoded. So I just pushed a PNG to the repo. Which was a major relief.
  2. For whatever reason the top and left attributes which work great at 50% on other browsers need 20% and 2% value for them to work on Safari. I hate Apple.
  3. Before I confidently close this issue, I just want to see the site on ipad or something.

@tomschenkjr
Copy link
Contributor Author

10-4. @SEV2014 do you have an iPad to test http://chicago.github.io/food-inspections-evaluation/ ?

I just checked on Android phone and it works well.

@tomschenkjr
Copy link
Contributor Author

  • Note to self (@tomschenkjr) that I need to swap the Futura font stack to a "League Spartan", "Avenir Black", "futura_md_btbold", sans font stack for h1. The overshoots look odd and isn't consistent with the typeface used on the tech plan.

@SEV2014
Copy link

SEV2014 commented Feb 9, 2015

@tomschenkjr - I do not have an iPad to test.

@tomschenkjr
Copy link
Contributor Author

@SEV2014 - thanks, no problem.

@skishchampi - swing-by when you get in. Rod has an iPad to test.

@skishchampi
Copy link
Contributor

IE has its own set of issues.

ieproblem

ieproblem2

@tomschenkjr The shrink issue has been solved. Was caused by a fixed max-width parameter.

Will now focus on the problem with responsive text alignment.

@skishchampi
Copy link
Contributor

@tomschenkjr This is still risky as it is optimized for the ipad I had today. I am guessing the text will go out of control in iphone 6 plus or the larger ipad.

One quick fix is to use a ton of media queries.

By and large it is fine. But I can keep taking a look at it as and when more devices show up.

#Kitchen article position should not be absolute. But I haven't a fix that will work everywhere. Fixing for Safari breaks Chrome, Mozilla et al

img_0091

@SEV2014
Copy link

SEV2014 commented Feb 11, 2015

@skishchampi - Aakash - can you please advise if this item is ready to close as of 2/11/15 end of day?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants