ID3FrameStringContentParser crash fix #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Scytalion and thank you so much for the contribution 🙏. I will review the PR in the next days and I will merge it if I don't have any comments. |
|
Ps please @Scytalion support my work by starring ⭐️ this repo ⭐️ (if you still didn't do it) |
chicio
approved these changes
Apr 18, 2023
|
Seems good to me. I will merge and release a new version by the end of the week. Thank you so much again for the contribution 🙏 |
|
ps there are some linting problem. If you have time fix them (or i will fix before/after merge) |
|
Yes of course, no problem. I had no SwiftLint installed, until now :-). I moved the SwiftLint build phase into an extra script and added a fix for apple silicon SwiftLint brew installs. |
|
Version 4.6.0 released on cocoapods and for SPM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ID3FrameStringContentParser crash with invalid range
Description
Added a guard before data is accessed.
Motivation and Context
Some of my mp3 files are running into this crash.
How Has This Been Tested?
Added a unit test.
Types of changes
Checklist: