Fix key validation bug #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done for two reasons: 1. There's no reason for it to be an instance method, since it does not use the key 2. This gets us around the "hack" of creating a new AES instance with an empty key, which breaks our validation of the key
* They are of the correct length (64 hex chars) * They use only a secure source * They pack and unpack correctly * Converted the instance method to re-use the class method since key generation doesn't rely on any encryption state The :base_64 format output of the random keys is very strange, because you are base64 encoding the hex string, when the normal expectation is you would base64 encode the raw binary. But I have left it as-is for backwards compatibility.
They must be in the proper format and length: 64 character hex string Raising an Argument Error Also updated all examples with using a proper key Finally, added a CHANGELOG with the breaking changes
|
I'm giving up and closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5