Skip to content

Commit

Permalink
chore: remove index and about pages
Browse files Browse the repository at this point in the history
export functions in controllers from central location
  • Loading branch information
chidimo committed Mar 28, 2020
1 parent 7a5a1e1 commit 896fdb2
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 54 deletions.
25 changes: 0 additions & 25 deletions src/controllers/home.js

This file was deleted.

1 change: 1 addition & 0 deletions src/controllers/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './message';
20 changes: 20 additions & 0 deletions src/controllers/message.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { Messages } from '../models/models';

export const messagesPage = async (req, res, next) => {
try {
const messages = await Messages.find();
res.status(200).json({ messages });
} catch (err) {
next(err);
}
};

export const addMessage = async (req, res, next) => {
const { name, message } = req.body;
try {
const m = await Messages({ name, message }).save();
res.status(201).json({ success: true, message: m });
} catch (err) {
next(err);
}
};
8 changes: 3 additions & 5 deletions src/routes/index.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import express from 'express';

import home from '../controllers/home';
import { messagesPage, addMessage } from '../controllers';

const indexRouter = express.Router();

indexRouter.get('/', home.indexPage);
indexRouter.get('/about', home.aboutPage);
indexRouter.get('/messages', home.messagesPage);
indexRouter.post('/messages', home.addMessage);
indexRouter.get('/messages', messagesPage);
indexRouter.post('/messages', addMessage);

export default indexRouter;
28 changes: 4 additions & 24 deletions test/index.test.js → test/message.test.js
Original file line number Diff line number Diff line change
@@ -1,28 +1,6 @@
import { expect, server, BASE_URL } from './setup';

describe('Test home routes', () => {
it('get index page', done => {
server
.get(`${BASE_URL}/`)
.expect(200)
.end((err, res) => {
expect(res.status).to.equal(200);
expect(res.body.message).to.equal('Index page');
done();
});
});

it('get about page', done => {
server
.get(`${BASE_URL}/about`)
.expect(200)
.end((err, res) => {
expect(res.status).to.equal(200);
expect(res.body.message).to.equal('About page');
done();
});
});

it('get messages page', done => {
server
.get(`${BASE_URL}/messages`)
Expand All @@ -43,10 +21,12 @@ describe('Test home routes', () => {
server
.post(`${BASE_URL}/messages`)
.send(data)
.expect(200)
.expect(201)
.end((err, res) => {
expect(res.status).to.equal(201);
expect(res.body.message).to.equal('Saved successfully!');
expect(res.body.success).to.equal(true);
expect(res.body.message).to.have.property('name', data.name);
expect(res.body.message).to.have.property('message', data.message);
done();
});
});
Expand Down

0 comments on commit 896fdb2

Please sign in to comment.