Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166075761 Separate parameter validation from route logic #32

Merged
merged 2 commits into from
May 17, 2019

Conversation

chidimo
Copy link
Owner

@chidimo chidimo commented May 17, 2019

What does this PR do?

Separate parameter validation from route logic

Description of Task to be completed?

Move paramter validators into separate helper file.

How should this be manually tested?

  1. Clone the repo
  2. cd into the root folder on a cmd shell and run yarn install. PowerShell is fine also.
  3. Setup a PostgreSQL DB.
  4. Define a .env file in the root of the project and supply values for the following parameters
    JWT_SECRET=<json-web-token-secret>
    PGPASSWORD=<postgres-db-password>
    PGHOST=<postgres-db-host>
    PGUSER=<postgres-db-user>
    PGPORT=<postgres-db-port>
  5. Create a PostgreSQL database called testdb and run the following command on it with pgadmin
CREATE TABLE users (
	id SERIAL PRIMARY KEY,
	email VARCHAR NOT NULL UNIQUE,
    password VARCHAR NOT NULL,
    firstname VARCHAR DEFAULT '',
    lastname VARCHAR DEFAULT '',
    phone VARCHAR DEFAULT '',
    address jsonb DEFAULT '{"home": "", "office": ""}',
    status VARCHAR DEFAULT 'unverified',
    isAdmin BOOLEAN DEFAULT false
);
  1. Now run command yarn test

Any background context you want to provide?

Be sure to setup the database as instructed above

What are the relevant pivotal tracker stories?

166075761

Screenshots (if appropriate)

Nil

Questions:

Nil

@chidimo chidimo force-pushed the ch-refactor-validators-166075761 branch from 1fb6d7a to 73ae557 Compare May 17, 2019 12:27
@chidimo chidimo merged commit 8fea836 into develop May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant