Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165839919 Activate password change function #44

Merged
merged 5 commits into from
May 23, 2019

Conversation

chidimo
Copy link
Owner

@chidimo chidimo commented May 23, 2019

What does this PR do?

Build up password change function

Description of Task to be completed?

  1. Activate password change endpoint
  2. Improve test coverage

How should this be manually tested?

  1. Clone the repo
  2. cd into the root folder on a cmd shell and run yarn install. PowerShell is fine also.
  3. Setup a PostgreSQL DB.
  4. Define a .env file in the root of the project and supply values for the following parameters
    JWT_SECRET=<json-web-token-secret>
    DBNAME=<database-name>
    PGPASSWORD=<postgres-db-password>
    PGHOST=<postgres-db-host>
    PGUSER=<postgres-db-user>
    PGPORT=<postgres-db-port>
  5. Create a PostgreSQL database called testdb.
  6. Run command yarn test

Any background context you want to provide?

Nil

What are the relevant pivotal tracker stories?

165839919

Screenshots (if appropriate)

Nil

Questions:

Nil

- return the error instead of throwing it so that it can be handled
gracefully since unhandled promise  errors are now deprecated in node
- If user provides password, set it as his account password and email
user, else set a random password and email user

[Finishes #165839919]
@chidimo chidimo force-pushed the ft-change-password-165839919 branch from f010bb6 to 6f3ce50 Compare May 23, 2019 16:39
@chidimo chidimo merged commit 58db41d into develop May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant