Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in base_url inside authentication.js file #50

Merged
merged 2 commits into from
May 28, 2019

Conversation

chidimo
Copy link
Owner

@chidimo chidimo commented May 28, 2019

What does this PR do?

Fix bug in base_url inside authentication.js file

Description of Task to be completed?

  • Set const base_url = 'https://qcredit.herokuapp.com/api/v1'

How should this be manually tested?

  1. Clone the repo
  2. Open /UI/authentication.html in a browser
  3. Click the sign in or sign up tab.
  4. Enter the required credentials. You should be redirected to your dashboard, which will have up to date information coming from the api backend server. This data persists on all pages.

Any background context you want to provide?

Nil

What are the relevant pivotal tracker stories?

166280668

Screenshots (if appropriate)

Nil

Questions:

Nil

[Delivers #166280668]
- Logout from any authenticated page
- Show profile photo on all pages
@chidimo chidimo changed the title Fix bug in base_url inside authentication.js file Fix bug in base_url inside authentication.js file May 28, 2019
@chidimo chidimo merged commit 17efdfd into develop May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant