Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch whisper.load_model to use requests module #33

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Patch whisper.load_model to use requests module #33

merged 1 commit into from
Oct 9, 2022

Conversation

chidiwilliams
Copy link
Owner

No description provided.

@chidiwilliams
Copy link
Owner Author

whisper.load_model (via whisper._download) downloads the ASR models on startup using urllib.request.openurl which does not pick up the certifi certs added to the PyInstaller bundle. This change patches the load_model function using the requests module to make the HTTP requests instead.

@chidiwilliams chidiwilliams merged commit c39ace3 into main Oct 9, 2022
@chidiwilliams chidiwilliams deleted the fix-model-download branch October 9, 2022 16:20
@chidiwilliams
Copy link
Owner Author

Fixes #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@chidiwilliams