Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Data clarification and bugfix #68

Merged
merged 2 commits into from Jan 25, 2018
Merged

Conversation

SteRoy
Copy link
Contributor

@SteRoy SteRoy commented Nov 14, 2017

For the purposes of clarity for both end-users and in development:

  • Updated the import screeen checkbox text from "Mark as Test Data (prohibits Email sending)" to "Send emails to participants"
  • Renamed the variable which stores the value held by this checkbox from is_test to send_mail_option
  • Removed the inversion of this value when passing to NewViaImport

Secondly disabled the presently non-functional sendNewUserMail called from the import form which seems to catastrophically stop CSV imports.

SteRoy and others added 2 commits November 14, 2017 10:20
…(prohibits Email sending" to "Send emails to participants" for clarity.

Updated variable storing the value from "Send emails to participants" checkbox to send_mail_option.
Updated functionality for processing the input from import form via the "Send emails to participants" checkbox
@SteRoy SteRoy changed the title Import Data clarification Import Data clarification and bugfix Jan 25, 2018
@rscoates
Copy link
Collaborator

This looks good to me. @JakobReiter - can this be merged?

@rscoates rscoates merged commit 43685b6 into chief-nerd:master Jan 25, 2018
@SteRoy SteRoy mentioned this pull request Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants