Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Browserify/Webpack #200

Merged
merged 2 commits into from May 27, 2015

Conversation

aaronroberson
Copy link
Contributor

Added angular-loading-bar to module exports so that after installing via npm, the package can be required in the angular module dependency list such as:

angular.module('myApp', [require('angular-loading-bar')]);

This is helpful for Browserify and Webpack.

@chieffancypants
Copy link
Owner

I don't use either of those tools, but shouldn't this be linked to dist instead of src?

@aaronroberson
Copy link
Contributor Author

I used src because that is what package.json was pointing to previously but I see that bower.json is referencing build so I updated it to reflect the same.

@aaronroberson
Copy link
Contributor Author

@chieffancypants: I forgot to tag you in my response.

chieffancypants added a commit that referenced this pull request May 27, 2015
Added support for Browserify/Webpack
@chieffancypants chieffancypants merged commit cff758a into chieffancypants:master May 27, 2015
@chieffancypants chieffancypants added this to the next version milestone May 27, 2015
@chieffancypants
Copy link
Owner

Great thanks! I'll take your word for it that it's working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants