-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making angular-loading-bar be aware of 3rd party libraries using XHR requests by listening for events. #49
base: master
Are you sure you want to change the base?
Conversation
…libraries that also do XHR requests so that the loading bar it's also aware of these requests.
This is useful to work with angular.js + oboe.js. It can also be achieved by adding start/done methods. I personally prefer events. |
this would be really useful for use with the Parse.com javascript SDK! |
Yes please! |
This seems like a great addition, actually needing it right now. |
+1 |
Let me give this a little bump +1 |
@chieffancypants Are you interested in supporting this feature, if I resolve the merge conflicts? |
I don't use a 3rd party lib that does HTTP requests, I don't think @chieffancypants does either (so the motivation to merge and support this is going to be very low) Also there are no tests in this PR proving that either the new feature does not break current functionality or that the new feature works as expected |
@faceleg No tests here, true. I can write the tests for the new feature. The existing tests would prove that the new feature doesn't break current functionality, wouldn't they? I think it's a pretty simple change, so it wouldn't be much extra to support, and it would add a lot of flexibility to this already excellent package. You would be able to use it when the user is waiting for, not just HTTP requests by 3rd party libs, but Web Workers, or requests over WebSockets. I'm sure there are other possibilities too. But it's up to you guys. If you're not interested I can figure something else out. @faceleg @chieffancypants If I resolve the merge conflicts and add some tests, are you interested in this feature enough that you would review and consider merging? |
@mattbrunetti I'm interested yes |
Added feature: Be able to fire start / end request events from non-angular 3d party libraries that also do XHR requests so that the loading bar it's also aware of these requests.
In case that you are using Angular in combination with non-angular 3d party libraries, you can now fire custom 'cfpLoadingBar:start' and 'cfpLoadingBar:done' request events.