Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build process so that php-parser dependency is packaged for node #8

Closed
chiefmyron opened this issue Oct 14, 2022 · 1 comment · Fixed by #62
Closed

Fix build process so that php-parser dependency is packaged for node #8

chiefmyron opened this issue Oct 14, 2022 · 1 comment · Fixed by #62
Assignees

Comments

@chiefmyron
Copy link
Owner

Default pre-built php-parser library is packaged for the 'web' target, which means it is attempting to target 'window' when being registered.

Need to update build process so that php-parser library correctly targets 'node' instead, to avoid manual changes to compiled library.

@chiefmyron
Copy link
Owner Author

There's also something strange going on where debugging only works when the 'main' prop in package.json is set to 'out'. However, when 'main' is set to 'out', webpack produces a build that cannot reference the xml2js library correctly.

Need to standardise on webpack as the build process, and figure out how to support debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant