fix tests

chiefonboarding · Mar 26, 2024 · 27c5c68 · 27c5c68
1 parent 8d0eec1
commit 27c5c68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/back/admin/integrations/sync_userinfo.py b/back/admin/integrations/sync_userinfo.py
@@ -52,8 +52,9 @@ def create_users(self, new_users, commit=True):
         valid_ones = []
 
         if serializer.is_valid():
-            serializer.save(is_active=False, commit=commit)
-            if not commit:
+            if commit:
+                serializer.save(is_active=False)
+            else:
                 return serializer.validated_data
         else:
             # if we have errors, then only get the valid ones

diff --git a/back/admin/integrations/utils.py b/back/admin/integrations/utils.py
@@ -20,7 +20,7 @@ def get_value_from_notation(notation, value):
 
             try:
                 value = value[index]
-            except (TypeError, ValueError):
+            except (TypeError, ValueError, IndexError):
                 # keep errors consistent, we are only expecting a KeyError
                 raise KeyError