minminguard 1.9.1 crash

[kataki]

whenever i try to run minminguard 1.9.0 and 1.9.1 its crashing, i tried clearing data, uninstalling and installing, disabling all other modules in xposed but no luck at all
ver 1.9.0 was working fine until one day i noticed it started crashing and now 1.9.1 is doing the same
i uploaded logcat if you can check plz
https://www.dropbox.com/s/afkc4mlumhhq7lq/logcat_and_device_info.zip?dl=0
thanks & regards

[chiehmin]

Thanks for report and logcat:)

On Sat, Jun 6, 2015, 5:14 AM kataki notifications@github.com wrote:

whenever i try to run minminguard 1.9.0 and 1.9.1 its crashing, i tried
clearing data, uninstalling and installing, disabling all other modules in
xposed but no luck at all
ver 1.9.0 was working fine until one day i noticed it started crashing and
now 1.9.1 is doing the same
i uploaded logcat if you can check plz
https://www.dropbox.com/s/afkc4mlumhhq7lq/logcat_and_device_info.zip?dl=0
thanks & regards

—
Reply to this email directly or view it on GitHub
#29.

[pylerSM]

Did you try clearing app data?

[pylerSM]

Ok, you tried. Looks like app can't retrieve icon for some system app but that is not problem since we get default system one.

The strange thing is OutOfMemory error. Maybe we could add option to enable/disable icon loading if it used so much memory.

[chiehmin]

I think we can just surround the getIcon fuction with try and catch. Leave the icon blank if we can not retrieve it.

[kataki]

could be because of number of apps installed is too much around 800 apps?
today i tried also minminhide and its also crashing

[chiehmin]

This may be the reason

On Mon, Jun 8, 2015, 5:30 AM kataki notifications@github.com wrote:

could be because of number of apps installed is too much around 800 apps?

—
Reply to this email directly or view it on GitHub
#29 (comment)
.

[pylerSM]

So we should disable icons loading if number of apps is too high.

[pylerSM]

I tried to do something. #36 Please build test APK and verify it whether it still crashes.

[pylerSM]

Or maybe disable icon loading if show system apps is enabled (since this option increases number of apps in apps list)

p.s: working workaround we can apply for MinMinHide too.

[pylerSM]

People with 700-800 apps get crashes. So I would try limit 500 apps.

[chiehmin]

This is a similar question on stackoverflow.

http://stackoverflow.com/questions/16958879/getting-a-lot-of-app-icons-make-out-of-memory

[pylerSM]

Yes, but I am not sure what we exactly need that way. It would require some more changes and and I don't think we can live without icons (when users has 500 and more apps). Search is still there.

So I prefer simple, elegant solution.
Idea: if showSystemApps is enabled and number of apps (user+system) > 500, don't load app icons. I will adjust commit with this logic.

[pylerSM]

Done. @chiehmin please build test APK with this change PR36 for guys to test it with so maaaany apps.

[kataki]

I tried v2.0.0 its still crashing
log
https://www.dropbox.com/s/afkc4mlumhhq7lq/logcat_and_device_info.zip?dl=0

[pylerSM]

Because fix was not merged yet.

[kataki]

thanks, any idea when the fix will be merged?

[pylerSM]

When FatMinMin will have time for it.

[chiehmin]

Should be fixed by commit a7554f1

[ilan-schemoul]

Same here even though with 2.0. But I'm not here for that but to express my happiness because I find somebody else who have +600 apps. When I used buzz launcher I sent an email to complain about the fact that the folder where limited to 100 and so I had to create 3 for my games. They say that I was the first one who find this limit. So I DL nova which even more famous than buzz (tough buzz have +10M) but it crash when I started to put app in a folder. I felt in love with action launcher and buy the pro but starting from 50 apps in a single folder the launcher crash and lag if I put outside. I reported via email 4month ago but still buggy and on Google plus few days before but it seemed that I'm the only one to have problem with launcher. And even worst on action launcher no one of millions of users seemed to have +50 apps. I search for a long time people like me, thanks kataki

[ilan-schemoul]

It works now