New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(advancecontrol): new advance control #240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into advanceDemo
…into advanceDemo
Codecov Report
@@ Coverage Diff @@
## develop #240 +/- ##
===========================================
- Coverage 46.18% 40.35% -5.83%
===========================================
Files 55 62 +7
Lines 2501 2887 +386
Branches 326 446 +120
===========================================
+ Hits 1155 1165 +10
- Misses 1273 1650 +377
+ Partials 73 72 -1
Continue to review full report at Codecov.
|
tomasen
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new components to realize it
vuex:
add fontSize and style to Subtitle.js
add tracks to Video.js
use InforCard.vue to realize background
different size :
P1(514 ~ 854) 1.0
P2(855 ~ 1920) 1.2
P3(1921 ~ ) 1.2 * 1.4
todo :
use winWidth may cause performance issue
need to fix subtitle fontSize and subtitle style
need to realize subtitle delay 、audio delay
need to add test