Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(advancecontrol): new advance control #240

Merged
merged 40 commits into from Nov 14, 2018

Conversation

Pat1enceLos
Copy link
Contributor

@Pat1enceLos Pat1enceLos commented Nov 12, 2018

  • add new components to realize it

  • vuex:
    add fontSize and style to Subtitle.js
    add tracks to Video.js

  • use InforCard.vue to realize background

  • different size :
    P1(514 ~ 854) 1.0
    P2(855 ~ 1920) 1.2
    P3(1921 ~ ) 1.2 * 1.4

  • todo :
    use winWidth may cause performance issue
    need to fix subtitle fontSize and subtitle style
    need to realize subtitle delay 、audio delay
    need to add test

Pat1enceLos and others added 28 commits November 5, 2018 13:26
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #240 into develop will decrease coverage by 5.82%.
The diff coverage is 3.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
- Coverage    46.18%   40.35%   -5.83%     
===========================================
  Files           55       62       +7     
  Lines         2501     2887     +386     
  Branches       326      446     +120     
===========================================
+ Hits          1155     1165      +10     
- Misses        1273     1650     +377     
+ Partials        73       72       -1
Impacted Files Coverage Δ
src/renderer/store/mutationTypes.js 100% <ø> (ø) ⬆️
src/renderer/store/actionTypes.js 100% <ø> (ø) ⬆️
src/renderer/components/BaseIconContainer.vue 50% <ø> (ø) ⬆️
src/renderer/components/NotificationBubble.vue 21.42% <ø> (ø) ⬆️
src/renderer/components/PlayingView/InfoCard.vue 0% <0%> (ø)
src/renderer/components/PlayingView/RateLabel.vue 0% <0%> (ø)
src/renderer/main.js 38.15% <0%> (-2.27%) ⬇️
...renderer/components/PlayingView/AdvanceControl.vue 0% <0%> (ø) ⬆️
...rc/renderer/components/PlayingView/VideoCanvas.vue 56.41% <0%> (-1.49%) ⬇️
...vanceControlFunctionalities/AdvanceColumnItems.vue 0% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ed57c...3f8cde8. Read the comment docs.

@tomasen tomasen merged commit 6ba70bb into chiflix:develop Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants