Major update to 3dviewer, update threejs and migrate all deprecated logic #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All new shadow system (no more shader) Fixed all the deprecation warnings New font loader flow Added anti-aliasing toggle (requires reload) Saving shadow/aa state in local storage
Restructured class vars to the top of the class General readability stuff
…ly with BufferGeometry Big cleanup on the THREE.JS gcode object creation, preparing for a cleaner implementation of all of the tweening and line highlight logic Lots of duplicate state has been removed
- fixed issue with inspector and lines
dchote
changed the title
|
In checking out your workspace, you are loading the Touch Plate widget,
which may, or may not, load the three.js dependency before your 3d viewer
does, but that would be random just based on browser loading order of
operations of external files. So, you may find inconsistencies in the
future based on that randomness.
…On Sun, May 7, 2017 at 11:42 AM, Daniel Chote ***@***.***> wrote:
Reopened #12 <#12>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHidbWkLv-_Hi9kWunlpOLQPLtMHfOmUks5r3hCsgaJpZM4NTQEk>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John, I think this is ready for a review and merge if you want to take a look.
Now using the latest THREE.js, and have tested on my CNC.
I have not tested how other plugins may be impacted, but its working great in my workspace. http://chilipeppr.com/dchote