Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing the Document::id method #42

Closed
cmbrandenburg opened this issue Apr 16, 2016 · 0 comments
Closed

Consider removing the Document::id method #42

cmbrandenburg opened this issue Apr 16, 2016 · 0 comments
Assignees
@cmbrandenburg
Labels
breaking change
Milestone
v0.2.0

Comments

@cmbrandenburg
Copy link
Collaborator

Document provides a path method returning a DocumentPath. The document id should be gotten from the path, not from a special Document::id method.
@cmbrandenburg cmbrandenburg added this to the v0.2.0 milestone Apr 16, 2016
jgillich added a commit to jgillich/chill that referenced this issue Apr 18, 2016
@jgillich
display Document::path() in the docs
a70efca 
ref chill-rs#42
@jgillich jgillich mentioned this issue Apr 18, 2016
Merged
@cmbrandenburg cmbrandenburg self-assigned this May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmbrandenburg cmbrandenburg

Labels
breaking change
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@cmbrandenburg