Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent automatic connection closure #60

Closed
wants to merge 1 commit into from

Conversation

ArcanoxDragon
Copy link

My application shares a MySQL connection with express-mysql-session and handles closing the connection by itself. I need to have express-mysql-session clear its expiry interval so the application doesn't hang, but I don't want my SQL connection to be closed when I call store.close(). This new option defaults to current behavior so this should not be a breaking change.

@chill117
Copy link
Owner

I assume you aren't using clearExpirationInterval() because you are concerned with it not being explicitly a "public" method? We could add another method that would be intended for public use; perhaps something like stopClearingExpiredSessions.

@ArcanoxDragon
Copy link
Author

I just realized this PR is probably awaiting my reply...

I suppose I can use clearExpirationInterval(), but as you said, I wasn't sure if it was necessarily a "public" method that was safe to rely on API-wise.

@chill117
Copy link
Owner

Yes, feel free to use clearExpirationInterval. It won't be changed.

@chill117 chill117 closed this Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants