Merge pull request #11 from fcarreiro/patch-1

Reconnect when error is fatal
chill117 · Sep 15, 2016 · da0e324 · da0e324
2 parents 8603e49 + b29042a
commit da0e324
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -210,7 +210,7 @@ MySQLConnectionManager.prototype.listenForDisconnect = function() {
 
 		debug('Connection error: "' + error.code + '"');
 
-		if (error.code == 'PROTOCOL_CONNECTION_LOST') {
+		if (error.fatal) {
 			this.disconnected();
 		}
 

diff --git a/test/unit/is-connected.js b/test/unit/is-connected.js
@@ -67,7 +67,7 @@ describe('MySQLConnectionManager#isConnected()', function() {
 			manager.once('disconnect', done);
 
 			manager.connection.destroy();
-			manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+			manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 		});
 
 		it('should return FALSE', function(done) {
@@ -113,7 +113,7 @@ describe('MySQLConnectionManager#isConnected()', function() {
 			});
 
 			manager.connection.destroy();
-			manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+			manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 		});
 
 		it('should return TRUE', function(done) {

diff --git a/test/unit/keep-alive.js b/test/unit/keep-alive.js
@@ -273,7 +273,7 @@ describe('MySQLConnectionManager#', function() {
 				});
 
 				manager.connection.destroy();
-				manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+				manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 			});
 
 			it('should not send keep-alive signals', function(done) {
@@ -328,7 +328,7 @@ describe('MySQLConnectionManager#', function() {
 				});
 
 				manager.connection.destroy();
-				manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+				manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 			});
 
 			it('should send keep-alive signals', function(done) {

diff --git a/test/unit/reconnect.js b/test/unit/reconnect.js
@@ -51,7 +51,7 @@ describe('MySQLConnectionManager#', function() {
 					timeout = setTimeout(done, 50);
 
 					manager.connection.destroy();
-					manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+					manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 				});
 			});
 		});
@@ -151,7 +151,7 @@ describe('MySQLConnectionManager#', function() {
 					}, 80);
 
 					manager.connection.destroy();
-					manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+					manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 
 				});
 			});
@@ -266,7 +266,7 @@ describe('MySQLConnectionManager#', function() {
 				}
 
 				manager.connection.destroy();
-				manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+				manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 			});
 		});
 	});
@@ -309,7 +309,7 @@ describe('MySQLConnectionManager#', function() {
 			});
 
 			manager.connection.destroy();
-			manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST' });
+			manager.connection.emit('error', { code: 'PROTOCOL_CONNECTION_LOST', fatal: true });
 		});
 
 		it('should be able to run a query on the connection object', function(done) {