Fix handling of 'A' records, which were previously ignored. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you have to remove the TTL argument as well? |
|
@comster good question. I wrote this PR nearly 3 years ago, but I seem to remember it working fine. I think the TTL may be set (line 102) but not in the test XML, which may be a little misleading. Either way I'd be very surprised if this gets merged after all this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of nice-route53 'A' records are not returned from the #records() call, as they do not contain a ResourceRecords entry, instead having an AliasTarget.
I have updated the tests and the code itself to handle this scenario, hope it's inline with your contribution format.