Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] go lang support as a build sytle #102

Closed
wants to merge 1 commit into from

Conversation

yopito
Copy link
Contributor

@yopito yopito commented Aug 8, 2022

golang support as a build style, and some packaging to illustrate its usage.
apart from various WIP stuff in packages, I'll be glad with some informal review of this build style.

@q66
Copy link
Contributor

q66 commented Aug 8, 2022

thanks, i don't think we need this right now but once things are a bit more stable we can work out some review

@q66
Copy link
Contributor

q66 commented Oct 2, 2022

i wasn't happy with the whole gcompat nonsense so i experimented with generating toolchains and at that point i was far enough to have a working template, so that's in the repo now, i suggest dropping the toolchain from here and also drop gcompat because it makes no sense for chimera (any binaries you'd want to run with that would be linked with libgcc, and we don't have that and there is a good chance we never will)

we can try getting in the build style eventually (it looks like it needs a lot of work though)

the random software should be standalone pull requests

@yopito
Copy link
Contributor Author

yopito commented Oct 2, 2022

OK, i'll rework this PR, only with the go build style.

@yopito yopito force-pushed the pkg.WIP.golang branch 2 times, most recently from 92731f7 to 0068c87 Compare October 6, 2022 05:56
src/cbuild/util/golang.py Outdated Show resolved Hide resolved
@vazub
Copy link

vazub commented Apr 18, 2023

I've tried the style and it works rather well overall. One thing that requires further investigation is that the app I've built did get debug symbols stripped, but a separate -dbg subpackage was not created.

@yopito
Copy link
Contributor Author

yopito commented Apr 18, 2023

I've tried the style and it works rather well overall. One thing that requires further investigation is that the app I've built did get debug symbols stripped, but a separate -dbg subpackage was not created.

I gave a try for -dbg: indeed such a package are generated. But lldb does not seem to use these debug symbols (below /usr/lib/debug) according to its comand "image list"
It seems that debugging a go binary with lldb requires dedicated flags at build time according to the old doc: https://ribrdb.github.io/lldb/
But I'm not clever enough about debugging technics of go binaries.

src/cbuild/util/golang.py Outdated Show resolved Hide resolved
Copy link

@vazub vazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to merge, unless @q66 has any additional concerns/requirements.

@q66 q66 closed this in efa73f2 May 21, 2023
@q66
Copy link
Contributor

q66 commented May 21, 2023

i did a preliminary merge of this after some cleanup/adjustments, but without the documentation; only stable interfaces can be documented and i plan to not make this stable for a while (just like cargo)

@yopito yopito deleted the pkg.WIP.golang branch May 21, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants